Ignore error for making identical deals#427
Merged
Merged
Conversation
added 2 commits
December 9, 2023 06:52
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #427 +/- ##
==========================================
+ Coverage 74.09% 74.14% +0.05%
==========================================
Files 150 150
Lines 9940 9944 +4
==========================================
+ Hits 7365 7373 +8
+ Misses 1819 1816 -3
+ Partials 756 755 -1 ☔ View full report in Codecov by Sentry. |
gammazero
approved these changes
Dec 29, 2023
Sankara-Jefferson
pushed a commit
that referenced
this pull request
Jun 14, 2025
In the case where provider failed to return success response, Singularity will retry the same deal which may end up with being rejected as boost has already received the same deal proposal. This makes Singularity continue to next deal instead of keep retrying on the same "identical deal" error message. --------- Co-authored-by: liuziba <lisashane16@gmail.com>
anjor
pushed a commit
to anjor/singularity
that referenced
this pull request
Jun 14, 2025
In the case where provider failed to return success response, Singularity will retry the same deal which may end up with being rejected as boost has already received the same deal proposal. This makes Singularity continue to next deal instead of keep retrying on the same "identical deal" error message. --------- Co-authored-by: liuziba <lisashane16@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case where provider failed to return success response, Singularity will retry the same deal which may end up with being rejected as boost has already received the same deal proposal.
This makes Singularity continue to next deal instead of keep retrying on the same "identical deal" error message.